-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit testing #9
Unit testing #9
Conversation
Hi @Team Invalid Code Review RequestYou have submitted a project, that has linter errors please fix it 👍🏿 Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏 Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. Invalid Code Review Request does not count into the code reviews limit. |
… into Unit-Testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AnsarIbrahim, @hassanShakur & @aamir-asaram 👋,
You're doing a good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Properly written unit tests ✔
- Proper use of
it
anddescribe
block ✔ - All tests are passing ✔
- Correct use of Git Flow ✔
- All linter checks are passing ✔
- Descriptive PR title with a good summary ✔
Required Changes ♻️
- Check the comments under the review.
- you just have to make a few changes and you're on your way 🚀.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
…-Library into Unit-Testing
… into Unit-Testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AnsarIbrahim, @hassanShakur, @aamir-asaram
Approved 🟢 🟢
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- All tests are passing 💯
- Tests cover every class and method 👍
- Clean and organized code 🟢 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
This PR Contains:
Project requirements
Add unit tests for all the methods in all the classes: