Fix issue with incorrect database_size when requesting a smaller shared_file_size
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hared_file_size`
heifner
reviewed
Nov 8, 2023
| @@ -134,7 +134,8 @@ pinnable_mapped_file::pinnable_mapped_file(const std::filesystem::path& dir, boo | |||
| std::filesystem::resize_file(_data_file_path, shared_file_size); | |||
| } | |||
| else if(shared_file_size < existing_file_size) { | |||
| std::cerr << "CHAINBASE: \"" << _database_name << "\" requested size of " << shared_file_size << " is less than " | |||
| _database_size = existing_file_size; | |||
| std::cerr << "CHAINBASE: \"" << _database_name << "\" requested size of " << shared_file_size << " is less than " | |||
There was a problem hiding this comment.
I think this code would be clearer if the constructor used _database_size instead of shared_file_size.
There was a problem hiding this comment.
I don't disagree that it is not very clear. This is for a 5.0 issue, so I'd rather make a small change.
Also we have this (maybe unintuitive) behavior that we allow the user to request a smaller size, but if the database already exist and is larger we just use the existing size without shrinking it (which would be difficult).
heifner
approved these changes
Nov 8, 2023
spoonincode
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28 .
This makes sure our
_database_sizemember tracks the actual size of the file we are mmap'ing into memory.