avoid invalid iterator dereference in get_allocator()
#34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_allocator()
needs to return the bip allocator for a given pointer based on looking up that pointer in a global map of address ranges, or return nullopt_t if the pointer is not within any address range (which means it wasn't allocated in a bip allocator, such as being allocated on stack).Consider there is a single range registered (
_segment_manager_map.size() == 1
) and this range is from 0x2000 to 0x4000.get_allocator(0x5000)
will causeupper_bound()
to returnend()
. Then reversing the iterator by one via*(--it)
will return the 0x2000-0x4000 entry, theif (object < seg_end)
check fails, and nullopt_t is returned as expected.But
get_allocator(0x1000)
will returnbegin()
. This causes the*(--it)
to iterate off the valid range and dereference an invalid iterator.Add a check for
begin()
and immediately return nullopt_t.