expose amount of memory in chainbase_node_allocator's free list
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Aug 13, 2024
greg7mdp
approved these changes
Aug 13, 2024
| @@ -398,6 +400,16 @@ namespace chainbase { | |||
| return _db_file.get_segment_manager()->get_free_memory(); | |||
| } | |||
|
|
|||
| size_t get_reclaimable_memory() const { | |||
| size_t ret = 0; | |||
| for(const unique_ptr<abstract_index>& ai_ptr : _index_map) { | |||
There was a problem hiding this comment.
Could we use _index_list instead of _index_map?
There was a problem hiding this comment.
I think so, yes, but we should also make the change elsewhere for consistency if doing that (I just copied what was being done elsewhere here). There likely isn't much of a benefit beyond skipping the if(!ai_ptr) check though (which is nice to skip!), since the _index_map is still -- practically speaking -- small and just another vector anyways.
There was a problem hiding this comment.
Oh, OK, it was not clear to me that the _index_map was small as well, because of the comment at line 561:
This is a full map (size 2^16) of all possible index designed for constant time lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new accessor to chainbase,
get_reclaimable_memory(), which returns the amount of memory tied up in allchainbase_node_allocators' free lists (this is memory not reported inget_free_memory())