cleanup initialization and move operations for pinnable_mapped_file
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Aug 15, 2024
spoonincode
reviewed
Aug 15, 2024
| o._segment_manager = nullptr; | ||
| o._writable = false; //prevent dtor from doing anything interesting | ||
| // all members are correctly default-initialized, so we can just move into *this | ||
| *this = std::move(o); |
There was a problem hiding this comment.
Wouldn't this leave items like _segment_manager and _writable still "live" from what is being moved from? The old move constructor nulls these out so the dtor doesn't do stuff to something that has been moved from, but now it seems like it would
There was a problem hiding this comment.
I believe this would execute pinnable_mapped_file::operator=(pinnable_mapped_file&& o), which swaps all the members, so o._segment_manager would get the current value of this->_segment_manager which is nullptr as initialized in the member declaration.
spoonincode
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinnable_mapped_filehas some member which are not consistently initialized or updated when constructed or assigned to with an rvalue:_database_size_writable_sharableAlso , in the move assignment operator, we overwrite
_segment_managerwithout giving it a chance to be removed from the static_segment_manager_map.This PR attemps to cleanup the construction and
moveoperations.