-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster support (custom types) #2
base: master
Are you sure you want to change the base?
Conversation
This goes at the same level as the |
no in the options object not in the style object |
Actually line 150 uses the style as a backup for type. |
Only issue left, is that click doesn't work for the cluster layers. The contraflow layer click handler is firing instead, even though it has a lower zindex.. |
|
||
* a cluster ruleset (pre-unified API - July 2016?) | ||
|
||
```json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is js code not json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
is there a branch of something that has this ? |
The contraflow alpha uses this, and you can see the clicking issue there. |
ah so cluster layers don't actually support hovering, which is what we use to handle clicks, so we probably just want to handle both the entrance and exit clicks in the contraflow handler, e.g. do getInfo calls on them both |
We can probably not merge this PR, since we aren't using clusters yet, and MapLarge hasn't finished them yet. |
ok @knownasilya try this with a
type: 'markerCluster'
in the options object