Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster support (custom types) #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

calvinmetcalf
Copy link
Member

ok @knownasilya try this with a type: 'markerCluster' in the options object

@knownasilya
Copy link
Contributor

This goes at the same level as the range option?

@calvinmetcalf
Copy link
Member Author

no in the options object not in the style object

@knownasilya
Copy link
Contributor

Actually line 150 uses the style as a backup for type.

@knownasilya knownasilya changed the title add custom type Add cluster support (custom types) May 19, 2016
@knownasilya
Copy link
Contributor

knownasilya commented May 19, 2016

Only issue left, is that click doesn't work for the cluster layers. The contraflow layer click handler is firing instead, even though it has a lower zindex..


* a cluster ruleset (pre-unified API - July 2016?)

```json
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is js code not json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@calvinmetcalf
Copy link
Member Author

is there a branch of something that has this ?

@knownasilya
Copy link
Contributor

The contraflow alpha uses this, and you can see the clicking issue there.

@calvinmetcalf
Copy link
Member Author

ah so cluster layers don't actually support hovering, which is what we use to handle clicks, so we probably just want to handle both the entrance and exit clicks in the contraflow handler, e.g. do getInfo calls on them both

@knownasilya
Copy link
Contributor

We can probably not merge this PR, since we aren't using clusters yet, and MapLarge hasn't finished them yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants