DroneCAN: added FlexDebug support #28450
Open
+166
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpwrules
reviewed
Oct 24, 2024
|
|
||
| // new message ID, add to the list. Note that this gets called | ||
| // only from one thread, so no lock needed | ||
| auto *p = NEW_NOTHROW FlexDebug; |
There was a problem hiding this comment.
Concerned that DroneCAN devices can cause arbitrary amounts of flight controller memory to be consumed that is never released. I think there should be a Lua call that allocates a fixed size buffer (or at least sets a limit on the number of allowed allocations) like with the scripting CAN buffers.
There was a problem hiding this comment.
I don't think it will be a problem in practice, as amount of memory for a scripting capable flight controller isn't much
we could reduce the ram by only allocating up to the actual length of the message
allows lua to retrieve vendor specific data from CAN nodes
tridge
force-pushed
the
pr-DroneCAN-FlexDebug
branch
from
7cc5dc6
to
49132f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows lua scripts to receive FlexDebug DroneCAN messages, allowing for flexible arbitrary debug data from peripheral nodes
This was developed for debugging AM32 ESCs, but any vendor can reserve ranges of IDs