Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new DATAGNSS GEM1305 RTK receiver #6335

Closed
wants to merge 69 commits into from
Closed

add new DATAGNSS GEM1305 RTK receiver #6335

wants to merge 69 commits into from

Conversation

datagnss
Copy link

add new GEM1305 RTK receiver.

Hwurzburg
Hwurzburg requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs ArduPilot parameter setup information, iincluding moving baseline info if it can be configured for that

@datagnss datagnss closed this Oct 18, 2024
@datagnss
Copy link
Author

not what I requested...what AP params need setting? also vscode commit should be removed

Updated.

Hwurzburg
Hwurzburg requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I squashed, and noticed a things

common/source/docs/common-datagnss-gem1305-rtk.rst Outdated Show resolved Hide resolved
common/source/docs/common-datagnss-gem1305-rtk.rst Outdated Show resolved Hide resolved
common/source/docs/common-datagnss-gem1305-rtk.rst Outdated Show resolved Hide resolved
@datagnss
Copy link
Author

I squashed, and noticed a things

I see, already be updated.

Hwurzburg
Hwurzburg requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your last commits undid my squash and fix for the incorrect .vscode library changes.....
please remove the .vscode changes and squash to one commit instead of 67 commits..

@datagnss datagnss closed this Oct 22, 2024
@datagnss
Add GEM1305 with case
6a3081d 
Update common-datagnss-gem1305-rtk.rst

Update common-datagnss-gem1305-rtk.rst

add the description for GEM1305 with case

update the config for output rate

update the format

Update common-datagnss-gem1305-rtk.rst
@datagnss
Merge branch 'master' of https://github.com/datagnss/ardupilot_wiki
3ea4f3a
@datagnss datagnss reopened this Oct 22, 2024
@datagnss datagnss closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hwurzburg Hwurzburg Hwurzburg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datagnss @Hwurzburg