-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jp/tests 20241224 #674
Draft
JamesPiechota
wants to merge
15
commits into
release/N.2.9.0-early-adopter
Choose a base branch
from
jp/tests-20241224
base: release/N.2.9.0-early-adopter
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Jp/tests 20241224 #674
+1,292
−1,159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the reset requency is set too long it causes a lot of blocks to be rejected which can cause some tests to timeout
introduced when we added solution rebasing
Sometimes 2 or more blocks are mined concurrently which can mess with the wait_until_height logic
JamesPiechota
force-pushed
the
jp/tests-20241224
branch
from
December 25, 2024 22:11
08a0ee3
to
645160c
Compare
Make pause_performance_reports a call instead of a cast to avoid a rare situation where the test proceeds before the reports are paused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.