Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved notes function, added additional test #28

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

SebastianBoldt
Copy link
Contributor

The notes function worked with single-octave chords but struggled with multi-octave chords.

I did a rework and added comments for clarification, it should now work properly.

Note(.D, octave: 5),
Note(.F, octave: 5),
Note(.A, octave: 5),
Note(.C, octave: 6),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

@aure aure merged commit 95ed13e into AudioKit:main Jan 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants