Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRankedChords() now removes duplicate non accidental chords #32

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

maksutovic
Copy link
Collaborator

Chords without an accidental root note (like C major, D Major, etc...) will not be duplicated in getRankedChords(from pitchSet: pitchSet)


func testDuplicateRankedChords() {
let midiNotes: [Int8] = [60, 64, 67]
let pitchSet = PitchSet(pitches: midiNotes.map { Pitch($0) } )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)

@aure aure merged commit 1bf3296 into AudioKit:main Feb 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants