Fix git-protocols, git-requests, api-requests, api-requests-by-user for GHES 3.11+ #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blongv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Github Enterprise Server 3.11 and later, log locations and formats have changed. For example, babeld no longer logs to /var/log/syslog. Instead, it logs to /var/log/babeld/babeld.log. Also, current_user is no longer in /var/log/github/unicorn.log; instead it is gh.actor.login. Lastly, haproxy is now called haproxy-frontend.
This PR includes fixes for four scripts:
Unfortunately, the admin user no longer has privileges to read babeld.log, but it has sudo NOPASSWD capability. The git-protocol.sh and git-requests.sh use mktemp and sudo to copy the babeld.log to a temporary directory, parse it and remove it.