Fix Horizontal Misalignment of Cells During Vertical Scrolling #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For columnar layouts, there should usually be be no need to estimate the x position of the column start in the viewport, as this information can be queried from `IColumns`. Make a new `GetOrEstimateAnchorElementForViewport` virtual method and override its behavior for columnar presenters. Fixes #298
grokys
force-pushed
the
fixes/298-cell-misalignment
branch
from
fed5361 to
39aa9c1
Compare
giard-alexandre
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For columnar layouts, there should usually be be no need to estimate the x position of the column start in the viewport, as this information can be queried from
IColumns. Make a newGetOrEstimateAnchorElementForViewportvirtual method and override its behavior for columnar presenters.Fixes #298