Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode-avalonia): prompt users to choose a solution file if workspace contains multiple #121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BinToss
Copy link
Contributor

@BinToss BinToss commented Mar 19, 2024

A re-open of #104

Resolves #101

This is similar to the implementations by OmniSharp, Ionide, ms-dotnettools.csharp, and others.

Note: commented code will not work until tc39/proposal-explicit-resource-management is formally part of ES. The commented code can be compiled with ESNext, but won't run in supported in VSCode <= v1.86.1

…space contains multiple

Commented code will not work until tc39/proposal-explicit-resource-management formally part of the ES. It can be compiled with ESNext, but it not supported in VSCode's runtime.
@BinToss
Copy link
Contributor Author

BinToss commented Mar 19, 2024

After this, I'll be creating several more Pull Requests to slowly get fixes, refactors, typo corrections, and other changes merged upstream.
See main...BinToss:AvaloniaUI.AvaloniaVSCode:main for the remaining changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getSolutionFile silently selects the first solution when multiple are found
2 participants