Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General-bug fixes #270

Merged
merged 6 commits into from
Jul 12, 2024
Merged

General-bug fixes #270

merged 6 commits into from
Jul 12, 2024

Conversation

oZakari
Copy link
Collaborator

@oZakari oZakari commented Jul 11, 2024 •
edited
Loading

Overview/Summary

Fixing various documented bugs. Also, fixing an undocumented bug where an EventHub recommendation was disabled when it should've active.

Related Issues/Work Items

Breaking Changes

  1. Removed WAF recommendations from AVD as no longer including them for specialized workloads as they expected to be incorporated for all workloads.

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@oZakari oZakari requested review from a team as code owners July 11, 2024 19:49
swathibhat1
swathibhat1 approved these changes Jul 11, 2024
View reviewed changes
Copy link

@swathibhat1 swathibhat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Changes look fine for AVD.

@oZakari oZakari added Bug 🐞 Something isn't working Area: Resource Guidance 📝 Improvements or additions to documentation Area: Resource Graph Query(s) #️⃣ Related to ARG queries labels Jul 11, 2024
@oZakari oZakari requested a review from a team July 11, 2024 21:21
tksh164
tksh164 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@tksh164 tksh164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@oZakari oZakari merged commit a9527a1 into Azure:main Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tksh164 tksh164 tksh164 approved these changes

@swathibhat1 swathibhat1 swathibhat1 approved these changes

Assignees
No one assigned
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@oZakari @tksh164 @swathibhat1