Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update AVD recommendations #322

Merged
merged 2 commits into from
Aug 1, 2024
Merged

docs: Update AVD recommendations #322

merged 2 commits into from
Aug 1, 2024

Conversation

moisesjgomez
Copy link
Contributor

@moisesjgomez moisesjgomez commented Jul 29, 2024 •
edited by oZakari
Loading

Overview/Summary

Update 99bf5c94-aa68-4bb3-8b7f-45d1c5f09b5d
Update d61f6ee8-de1b-4fd9-9ce3-316cfe11ee05

cc: @swathibhat1

https://dev.azure.com/CSUSolEng/Accelerator%20-%20AVD/_workitems/edit/36374

Breaking Changes

  1. Replace me
  2. Replace me

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@moisesjgomez moisesjgomez requested review from a team as code owners July 29, 2024 21:47
@azure-boards Azure Boards
Copy link

azure-boards bot commented Jul 29, 2024

❌ There was a problem linking to Azure Boards work item(s):

  • 123

Please check the IDs and try again using the AB# syntax. Learn more

@Azure Azure deleted a comment from azure-boards bot Jul 30, 2024
@Azure Azure deleted a comment from azure-boards bot Jul 30, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Jul 30, 2024

Hi @moisesjgomez, there are two failing checks for the PR that need to be addressed. Let me know if you have any questions about the required changes.

@ejhenry ejhenry added Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Jul 30, 2024
@moisesjgomez moisesjgomez changed the title Update AVD recommendations docs: Update AVD recommendations Jul 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Jul 30, 2024
@moisesjgomez
Copy link
Contributor Author

@ejhenry checks have been resolved. Thank you!

ejhenry
ejhenry approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @moisesjgomez LGTM 👍

@ejhenry
Copy link
Contributor

ejhenry commented Jul 31, 2024

@Azure/aprl-avd please review

@ejhenry ejhenry added the Needs: Attention from aprl-avd 👋 Needs attention from aprl-avd GitHub team. label Jul 31, 2024
swathibhat1
swathibhat1 approved these changes Jul 31, 2024
View reviewed changes
Copy link

@swathibhat1 swathibhat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Can be merged. Thank you.

@oZakari oZakari merged commit 06fbcc2 into Azure:main Aug 1, 2024
6 checks passed
@oZakari oZakari mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry approved these changes

@swathibhat1 swathibhat1 swathibhat1 approved these changes

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-avd 👋 Needs attention from aprl-avd GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moisesjgomez @ejhenry @swathibhat1 @oZakari