Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing recommendationTypeId value #328

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: add missing recommendationTypeId value #328

merged 1 commit into from
Aug 1, 2024

Conversation

ejhenry
Copy link
Contributor

@ejhenry ejhenry commented Jul 31, 2024

Overview/Summary

Add missing recommendationTypeId value for two recommendations

Related Issues/Work Items

Fixes #325

Breaking Changes

  1. None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ejhenry ejhenry requested review from a team as code owners July 31, 2024 23:32
@ejhenry ejhenry requested a review from tksh164 July 31, 2024 23:58
@ejhenry ejhenry added the Area: Resource Guidance 📝 Improvements or additions to documentation label Jul 31, 2024
tksh164
tksh164 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@tksh164 tksh164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit 5485812 into Azure:main Aug 1, 2024
6 checks passed
@ejhenry ejhenry deleted the fix-typeId branch September 19, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tksh164 tksh164 tksh164 approved these changes

@oZakari oZakari oZakari approved these changes

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

👂 Feedback - Empty recommendationTypeId
3 participants
@ejhenry @tksh164 @oZakari