Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix learn more links #343

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: Fix learn more links #343

merged 2 commits into from
Aug 13, 2024

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Aug 6, 2024

Overview/Summary

Fixed learn more links of Enable Network Security Group and Virtual Network Flow Logs.

  • The existing learn more link is describe only NSG flow logs.
  • The added learn more link is describe VNet flow logs.

Related Issues/Work Items

  • None

Breaking Changes

  • None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@tksh164 tksh164 requested review from a team as code owners August 6, 2024 06:48
@oZakari oZakari requested a review from a team August 9, 2024 02:17
@oZakari oZakari added Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team labels Aug 9, 2024
@maheshbenke maheshbenke added Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. and removed Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team labels Aug 9, 2024
@oZakari oZakari merged commit 640eff5 into Azure:main Aug 13, 2024
6 checks passed
@tksh164 tksh164 deleted the fix-recomm-a1317a0b branch August 27, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oZakari oZakari oZakari approved these changes

@jimays-avila jimays-avila jimays-avila approved these changes

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tksh164 @oZakari @jimays-avila @maheshbenke