-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AFD Recommendation added #361
Conversation
Update recommendations.yaml
Create new AFD recommendation and Add KQL for GUID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimays-avila thanks for the contribution. Looks like four of the PR checks are failing. Let me know if you need help working through any of them.
I will review it tomorrow and fix the issues @ejhenry thanks. |
@ejhenry I fixed most of the issue but am not sure how to fix the issue with for "Code Review - Linting & Link Checks / Lint code base". Could you help me with this one? I am still looking into it in between my calls. |
Hey @jimays-avila, it looks like it's trailing white space. You can either remove the extra white space manually or I recommend installing https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig for VSCode which will look for configs in repos and then try to align to them so you don't have to worry about it. |
@oZakari thanks I looked over that and did not see that. Let me fix that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
Added a recommendation around avoiding using AFD classic to the recommendations list and added the Guid.KQL
Related Issues/Work Items
AB#35190
#50
https://dev.azure.com/CSUSolEng/Azure%20Infra%20Networking/_workitems/edit/35190/
Breaking Changes
N/A
As part of this pull request I have
main
branch