Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AFD Recommendation added #361

Merged
merged 12 commits into from
Aug 28, 2024
Merged

feat: AFD Recommendation added #361

merged 12 commits into from
Aug 28, 2024

Conversation

jimays-avila
Copy link
Contributor

@jimays-avila jimays-avila commented Aug 19, 2024

Overview/Summary

Added a recommendation around avoiding using AFD classic to the recommendations list and added the Guid.KQL

Related Issues/Work Items

AB#35190
#50

https://dev.azure.com/CSUSolEng/Azure%20Infra%20Networking/_workitems/edit/35190/

Breaking Changes
N/A

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jimays-avila jimays-avila requested review from a team as code owners August 19, 2024 20:02
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimays-avila thanks for the contribution. Looks like four of the PR checks are failing. Let me know if you need help working through any of them.

@jimays-avila
Copy link
Contributor Author

I will review it tomorrow and fix the issues @ejhenry thanks.

@jimays-avila jimays-avila changed the title Add Recommendation to Front Door for customers using Classic #35190 Update AFD Recommendations Aug 21, 2024
@jimays-avila jimays-avila changed the title Update AFD Recommendations feat: AFD Recommendation added Aug 21, 2024
@jimays-avila jimays-avila enabled auto-merge (squash) August 21, 2024 15:27
@jimays-avila
Copy link
Contributor Author

jimays-avila commented Aug 21, 2024

@ejhenry I fixed most of the issue but am not sure how to fix the issue with for "Code Review - Linting & Link Checks / Lint code base". Could you help me with this one? I am still looking into it in between my calls.

@oZakari
Copy link
Collaborator

oZakari commented Aug 21, 2024

Hey @jimays-avila, it looks like it's trailing white space. You can either remove the extra white space manually or I recommend installing https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig for VSCode which will look for configs in repos and then try to align to them so you don't have to worry about it.
image

@jimays-avila
Copy link
Contributor Author

@oZakari thanks I looked over that and did not see that. Let me fix that now.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Aug 21, 2024
@jimays-avila
Copy link
Contributor Author

All issues have been resolved thanks @oZakari and @ejhenry.

oZakari
oZakari previously approved these changes Aug 21, 2024
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

azure-resources/Cdn/profiles/recommendations.yaml Outdated Show resolved Hide resolved
oZakari
oZakari previously approved these changes Aug 21, 2024
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry requested a review from oZakari August 27, 2024 03:47
@jimays-avila jimays-avila merged commit 67cdae5 into Azure:main Aug 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants