-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove "Configure NSG Flow Logs" deprecated recommendation + references #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have an official policy for APRL about when to remove guidance for services that are being retired? And how soon or not to remove the guidance? Currently I don't see a public announcement about the retirement.
That is:
Do we remove APRL guidance ASAP after retirement is announced? Or prior to the announcement?
Do we remove APRL guidance N days/months/years in advance of the retirement, but no sooner? (In this case it looks like 3 years)
The announcement was delivered via Health advisories in Service Health. |
Retirement: Network security group flow logs in Azure Network Watcher will be retired |
I recommend that as part of this change, new guidance under Virtual Networks be put in place for the configuration of Vnet flow logs. |
It already exists, but under Network Watcher component 👉 Enable NSG and Virtual Network Flow Logs That's why I didn't suggest it, to avoid duplicates. |
@oZakari I'm not sure to understand this one. If you submit back a PR on my forked repo main branch, won't that create a diff with the APRL upstream repo main branch? |
Hey @jdmsoss, thanks for calling that out. I didn't realize I was targeting your main branch, so I corrected it to the nsg-flowlogs branch associated to this PR. Please review and merge if you can now. |
fix: Updates to NSG Flow Logs Recommendation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
On 30 September 2027, NSG flow logs will be retired.
As part of this pull request I have
main
branch