Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude master DB from failover group recommendation #469

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: exclude master DB from failover group recommendation #469

merged 1 commit into from
Oct 23, 2024

Conversation

jdmsoss
Copy link
Contributor

@jdmsoss jdmsoss commented Oct 17, 2024

Overview/Summary

Master database should be excluded from "Auto Failover Groups can encompass one or multiple databases, usually used by the same app." recommendation result.

Before my fix 👇

before

After my fix 👇

after

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jdmsoss jdmsoss requested a review from a team as a code owner October 17, 2024 15:17
@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Oct 17, 2024
@oZakari oZakari added the PR: Safe to Test ARG Queries 🧪 Confirmation to allow testing of ARG queries label Oct 17, 2024
@oZakari oZakari closed this Oct 17, 2024
@oZakari oZakari reopened this Oct 17, 2024
oZakari
oZakari approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari requested a review from a team October 21, 2024 03:41
@oZakari oZakari closed this Oct 21, 2024
@oZakari oZakari reopened this Oct 21, 2024
@ramyerrabotu
Copy link
Contributor

Good to exclude the master DB

@ramyerrabotu ramyerrabotu merged commit 8259df3 into Azure:main Oct 23, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oZakari oZakari oZakari approved these changes

@ramyerrabotu ramyerrabotu ramyerrabotu approved these changes

Assignees
No one assigned
Labels
Bug 🐞 Something isn't working PR: Safe to Test ARG Queries 🧪 Confirmation to allow testing of ARG queries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdmsoss @ramyerrabotu @oZakari