Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Key Vault RBAC recommendation #479

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Key Vault RBAC recommendation #479

wants to merge 3 commits into from

Conversation

edknox
Copy link
Contributor

@edknox edknox commented Oct 23, 2024 •
edited by oZakari
Loading

Overview/Summary

As per the request of the Security Team the recommendation to use RBAC for Key Vault

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

2 Key Vaults in subscription (1 with RBAC, \ 1 without RBAC)
image

image

image

ARG query only returns the Key Vault without RBAC configured
image

@edknox edknox requested a review from a team as a code owner October 23, 2024 15:19
@oZakari oZakari changed the title Keyvaultupdate feat: Key Vault RBAC recommendation Oct 23, 2024
@oZakari oZakari added Type: Resource or Feature Deprecation 👻 A resource or resource feature is planned to be deprecated and/ore removed. Area: Resource Guidance 📝 Improvements or additions to documentation Area: Resource Graph Query(s) #️⃣ Related to ARG queries and removed Type: Resource or Feature Deprecation 👻 A resource or resource feature is planned to be deprecated and/ore removed. labels Oct 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Oct 23, 2024
oZakari
oZakari approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oZakari oZakari oZakari approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Enhancement 🆕 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edknox @oZakari