Log collector scenario should not pick up runs before service restart #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test * test * Rename agent log:
maddieford
requested review from
narrieta,
ZhidongPeng and
nagworld9
as code owners
narrieta
reviewed
Sep 23, 2024
| log.info("Renaming agent log file and modifying log collector conf flags") | ||
| setup_script = ("agent-service stop && mv /var/log/waagent.log /var/log/waagent.$(date --iso-8601=seconds).log && " | ||
| "update-waagent-conf Logs.Collect=y Debug.EnableCgroupV2ResourceLimiting=y Debug.LogCollectorInitialDelay=60") | ||
| self._run_remote_test(ssh_client, f"sh -c '{setup_script}'", use_sudo=True) |
There was a problem hiding this comment.
should be run_command, rather than run_remote_test
narrieta
approved these changes
Sep 23, 2024
nagworld9
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The log collector scenario does a service restart to update config flags. In some cases, a log collector run starts but does not complete before the service restart. The test is picking up the incomplete run.
This PR updates the scenario to rename the log before restarting the service so that the test only picks up log collector runs afte the service restart.
Issue #
PR information
Quality of Code and Contribution Guidelines