Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade go toolchain to 1.23 #3022

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: upgrade go toolchain to 1.23 #3022

wants to merge 1 commit into from

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Sep 19, 2024

Reason for Change:

Updates the Go version to v1.23.1 for various improvements, fixes to stdlib, and toolchain upgrades.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr enabled auto-merge September 19, 2024 18:27
@rbtr rbtr self-assigned this Sep 19, 2024
@rbtr rbtr added cns Related to CNS. npm Related to NPM. cni Related to CNI. ci Infra or tooling. go Pull requests that update Go code release/latest Change affects latest release train needs-backport Change needs to be backported to previous release trains dropgz dropgz labels Sep 19, 2024
@rbtr
Copy link
Contributor Author

rbtr commented Sep 19, 2024

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jpayne3506
jpayne3506 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is not a priority. We may want to look at leveraging the toolchain directive to have reproduceable builds for each of our releases/tags.

go.mod
@@ -1,6 +1,6 @@
module github.com/Azure/azure-container-networking

go 1.22.0
go 1.23.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the required go version to be above that of the defined toolchain depreciates its usage.

https://go.dev/ref/mod#go-mod-file-toolchain

@jpayne3506
Copy link
Contributor

Going to need to re-run the workflows with an updated ruleset for this to merge.

@rbtr
chore: upgrade go toolchain to 1.23
257ad68 
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@ZetaoZhuang ZetaoZhuang Awaiting requested review from ZetaoZhuang ZetaoZhuang is a code owner

@camrynl camrynl Awaiting requested review from camrynl camrynl is a code owner

@paulyufan2 paulyufan2 Awaiting requested review from paulyufan2 paulyufan2 is a code owner

@ashvindeodhar ashvindeodhar Awaiting requested review from ashvindeodhar ashvindeodhar is a code owner

@thatmattlong thatmattlong Awaiting requested review from thatmattlong thatmattlong is a code owner

@huntergregory huntergregory Awaiting requested review from huntergregory huntergregory is a code owner automatically assigned from Azure/acn-npm-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@rbtr rbtr

Labels
ci Infra or tooling. cni Related to CNI. cns Related to CNS. dropgz dropgz go Pull requests that update Go code needs-backport Change needs to be backported to previous release trains npm Related to NPM. release/latest Change affects latest release train
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbtr @jpayne3506