Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmos] remove react-native runtime dependency on isomorphic-webcrypto #23156

Closed

Conversation

jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented Sep 8, 2022

and delay accessing crypto api when needed instead of at module load time so that users have
a chance to polyfill the crypto api

Packages impacted by this PR

@azure/cosmos

Issues associated with this PR

#22628

…pto`

so that customers can provide crypto polyfills of their own choice.
@ghost ghost added the Cosmos label Sep 8, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Access crypto api when needed instead of at module load time so that users have
a chance to polyfill them.
@jeremymeng jeremymeng closed this Sep 20, 2022
@jeremymeng jeremymeng reopened this Sep 20, 2022
@jeremymeng
Copy link
Member Author

/check-enforcer reset

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Nov 25, 2022
@ghost
Copy link

ghost commented Nov 25, 2022

Hi @jeremymeng. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hi @jeremymeng. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmos no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants