feat: Pattern Module for Azure Update Manager #3771
Conversation
Each parameters' & UDT's description should start with a one word category starting with a capital letter, followed by a dot, a space and the actual description text ending with a dot.
avm-team-linter
bot
added
the
Needs: Core Team 🧞
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
akhilthomas011
changed the title
|
Hey @akhilthomas011 , Firstly, thanks for your work on this PR! We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs. Changes to CI That Have Been Made That You Need To Take Action On
Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams Thanks Jack (AVM Core Team) |
|
@jtracey93 - I have pulled-in the new changes to my PR. It passed the validations. |
| metadata version = '0.1.0' | ||
| metadata category = 'Compute' |
There was a problem hiding this comment.
What's about this metadata?
| //User Defined Types | ||
| @description('Defines the structure of a maintenance configuration.') | ||
| type maintenanceConfigurationType = { | ||
| @description('The name of the maintenance configuration.') |
There was a problem hiding this comment.
Missing metadata like the prefix category Mandatory / Optional / Conditional for all properties
| } | ||
| } | ||
| @description('The lock settings for the maintenance configuration.') | ||
| lock: object |
There was a problem hiding this comment.
For this you could import the lock type from the published avm-common-types module and use it here: lock: lockType?
| @description('The tags to apply to the maintenance configuration.') | ||
| tags: object? | ||
| @description('The role assignments for the maintenance configuration.') | ||
| roleAssignments: array? |
There was a problem hiding this comment.
For this you could import the role assignments type from the published avm-common-types module and use it here: roleAssignments: roleAssignmentType[]?
|
|
||
| @description('Optional. The name of the resource group to deploy for testing purposes.') | ||
| @maxLength(90) | ||
| // e.g., for a module 'network/private-endpoint' you could use 'dep-dev-network.privateendpoints-${serviceShort}-rg' |
There was a problem hiding this comment.
Please remove all example comments in this and other test files
| // ============ // | ||
| // Dependencies // | ||
| // ============ // | ||
|
|
||
| // General resources | ||
| // ================= | ||
|
|
avm/ptn/maintenance/azure-update-manager/tests/e2e/defaults/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/ptn/maintenance/azure-update-manager/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/ptn/maintenance/azure-update-manager/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…/main.test.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…/main.test.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…in.test.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Description
This PR adds the pattern module for Azure Update Manager.
The pattern creates multiple maintenance configurations and assigns them to ARC Servers/Azure VMs based on tags. The pattern also creates and assigns Azure Policies in the subscription to mandate maintenance configuration related Tags on Virtual machines on creation and do necessary config changes to be compatible with Azure Update Manager.
Closes #1144
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.