Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Azure Cosmos DB network settings ignored if child resources are not created #3822

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

seesharprun
Copy link
Contributor

@seesharprun seesharprun commented Nov 20, 2024

Description

Update publicNetworkAccess so it works even if you don't configure child resources (NoSQL, MongoDB, Gremlin, or Table)

Pipeline Reference

Pipeline
avm.res.document-db.database-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 20, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 20, 2024
@seesharprun seesharprun changed the title Cosmos db update fix: Azure Cosmos DB network settings ignored if child resources are not created Nov 20, 2024
@seesharprun seesharprun marked this pull request as ready for review November 20, 2024 22:12
@seesharprun seesharprun requested review from a team as code owners November 20, 2024 22:12
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Nov 20, 2024
@seesharprun
Copy link
Contributor Author

seesharprun commented Nov 21, 2024

@Azure/avm-res-documentdb-databaseaccount-module-owners-bicep

This is ready for review

@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Nov 24, 2024
Copy link
Contributor

@bryansan-msft bryansan-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
3 participants