feat: Add osSKU parameter back

[PixelRobots]

Signed-off-by: PixelRobots 22979170+PixelRobots@users.noreply.github.com

Description

Fixes #3595
Fixes #3819

Pipeline Reference

Pipeline

Type of Change

• Update to CI Environment or utilities (Non-module affecting changes)
• Azure Verified Module updates:
  • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
  • Breaking changes and I have bumped the MAJOR version in version.json.
  • Update to documentation

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• I have run Set-AVMModule locally to generate the supporting module files.
• My corresponding pipelines / checks run clean and green without any errors or warnings

[microsoft-github-policy-service]

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[microsoft-github-policy-service]

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

[AlexanderSehr]

Please note, while this PR looks absolutely fine as far as I'm concerned it will fail in upstream due to: #3646 who's underlying issue needs to be resolved first.
Mind while, while we got merge regardless, this would mean the module would not be published.

[JPEasier]

Let's bring some consistency here and let us always use osSKU.
default value is Ubuntu as per documentation:

Specifies the OS SKU used by the agent pool. If not specified, the default is Ubuntu if OSType=Linux or Windows2019 if OSType=Windows. And the default Windows OSSKU will be changed to Windows2022 after Windows2019 is deprecated.

Suggested change

	osSKU: profile.?osSku ?? 'AzureLinux'
	osSKU: profile.?osSKU'

[JPEasier]

Also please update osSku -> osSKU in the type definition, parameter definition and in agentPool.bicep
alternatively, I already have the changes in a branch of mine.
https://github.com/JPEasier/bicep-registry-modules/tree/users/jpeasier/avm-aks

[PixelRobots]

If you have the changes in your Branch already then, we can use that, and I can close this PR. When would you be pushing your branch?

[asw101]

Hi team, I also hit this issue this week trying to deploy AzureLinux. Just checking in on the ETA for the review/merge?

[AlexanderSehr]

Hi team, I also hit this issue this week trying to deploy AzureLinux. Just checking in on the ETA for the review/merge?

Hey @asw101,
we're currently awaiting some responses on this issue : #3646 to go first.

But if bad comes to worse @JPEasier & @ilhaan, let's remove the blocking preview feature from the module again. store the code in some branch, and contribute it back once we got answers to the pending questions.

[JPEasier]

Agree, this could be a good workaroud.

[asw101]

Thank you @AlexanderSehr & @JPEasier. Yes, whatever allows us to deploy AzureLinux sooner, even in the interim, would be wonderful.

I see AKS Automatic referenced as well, and that's something else my team uses heavily.