Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Aad aadProfile parameters to control AAD integrated clusters in Kubernetes #3928

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Menghua1
Copy link
Member

Description

Based on PR #3828 update to avm/res/container-service/managed-cluster, add aadProfile parameter to control AAD integration.

Pipeline Reference

Pipeline
avm.ptn.azd.aks

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@rajeshkamal5050 for notification.

@Menghua1 Menghua1 requested review from a team as code owners December 13, 2024 09:24
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 13, 2024
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Dec 13, 2024
@Menghua1
Copy link
Member Author

@AlexanderSehr Could you review this PR and merge it as soon as possible? Thank you very much!

@AlexanderSehr
Copy link
Contributor

Hey @Menghua1,
as mentioned a few times before, please note that I'm not the owner of the AKS module.
@JPEasier & @ilhaan would be in the driver seat here. 💪

@Menghua1
Copy link
Member Author

@JPEasier and @ilhaan Could you review this PR and merge it as soon as possible? Thank you very much!

@JPEasier
Copy link
Contributor

Hi @Menghua1, @AlexanderSehr,

this is the pattern Module
I am Not owner of this module.

However I can review it but this should be done by the owner.

@Menghua1
Copy link
Member Author

@AlexanderSehr and @JPEasier Thanks for the clarification. I don't know where to find the owner details for the module. Could you please guide me where to look? Thanks!

@Menghua1
Copy link
Member Author

@jongio We found that you are the owner of this module from this. Can you review this PR and merge it as soon as possible? Thanks.

@AlexanderSehr
Copy link
Contributor

My bad @JPEasier, @Menghua1 this would be @jongio.
You can find this detail in 2 places:

  1. If you hover over the (reviewer) group that was automatically set as the reviewer you can see that @jongio is a member
  2. The other location would be the AVM website. For Bicep Pattern specifically, you can find all modules & members here

@AlexanderSehr AlexanderSehr assigned jongio and Menghua1 and unassigned ilhaan and JPEasier Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants