Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ephemeral disk placement #3948

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Kittoes0124
Copy link

@Kittoes0124 Kittoes0124 commented Dec 17, 2024

Description

This adds support for ephemeral disk placement to the Virtual Machine module.

Non-breaking Changes:

  • Added optional diffDiskSettings property to osDisk parameter.
  • Added support for OIDC authentication.
  • Alphabetized type definitions.
  • Replaced common type definitions with AVM common type module imports.

Breaking Changes:

  • Refactored the enableEvictionPolicy parameter; it is now named evictionPolicy and matches the base resource type definition.

Pipeline Reference

Pipeline
avm.res.compute.virtual-machine

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 17, 2024
@Kittoes0124 Kittoes0124 changed the title feat: added support for ephemeral disk placement feat: add support for ephemeral disk placement Dec 17, 2024
@Kittoes0124 Kittoes0124 marked this pull request as ready for review December 17, 2024 23:37
@Kittoes0124 Kittoes0124 requested review from a team as code owners December 17, 2024 23:37
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Dec 17, 2024
@rahalan rahalan self-assigned this Dec 18, 2024
rahalan
rahalan previously approved these changes Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants