feat: Removed unused 'owner' metadata from templates including corresponding test #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSehr
added
Type: AVM 🅰️ ✌️ Ⓜ️
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
|
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
eriqua
reviewed
Dec 22, 2024
| @@ -228,7 +227,7 @@ | |||
| } | |||
| }, | |||
| "variables": { | |||
| "$fxv#0": "{\n // Recommended abreviations: https://learn.microsoft.com/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations\n \"resourceTypeAbbreviations\" : {\n \"applicationGateway\": \"agw\",\n \"applicationInsights\": \"appi\",\n \"appService\": \"app\",\n \"azureFirewall\": \"azfw\",\n \"bastion\": \"bas\",\n \"containerAppsEnvironment\": \"cae\",\n \"containerRegistry\": \"cr\",\n \"cosmosDbNoSql\": \"cosno\",\n \"frontDoor\": \"afd\",\n \"frontDoorEndpoint\": \"fde\",\n \"frontDoorWaf\": \"fdfp\",\n \"keyVault\": \"kv\",\n \"logAnalyticsWorkspace\": \"log\",\n \"managedIdentity\": \"id\",\n \"networkInterface\": \"nic\",\n \"networkSecurityGroup\": \"nsg\",\n \"privateEndpoint\": \"pep\",\n \"privateLinkService\": \"pls\",\n \"publicIpAddress\": \"pip\",\n \"resourceGroup\": \"rg\",\n \"routeTable\": \"rt\",\n \"serviceBus\": \"sb\",\n \"serviceBusQueue\": \"sbq\",\n \"serviceBusTopic\": \"sbt\",\n \"storageAccount\": \"st\",\n \"virtualMachine\": \"vm\",\n \"virtualNetwork\": \"vnet\",\n \"redisCache\": \"redis\",\n \"cognitiveAccount\": \"cog\",\n \"openAiDeployment\": \"oaidep\",\n \"azureAISearch\": \"srch\",\n \"documentIntelligence\": \"di\",\n \"eventGridSystemTopic\": \"egst\",\n \"eventGridSubscription\": \"evgs\"\n },\n\n //copied from here: https://github.com/nianton/azure-naming/blob/main/datafiles/regionAbbreviations.json\n \"regionAbbreviations\" : {\n \"australiacentral\": \"auc\",\n \"australiacentral2\": \"auc2\",\n \"australiaeast\": \"aue\",\n \"australiasoutheast\": \"ause\",\n \"brazilsouth\": \"brs\",\n \"brazilsoutheast\": \"brse\",\n \"canadacentral\": \"canc\",\n \"canadaeast\": \"cane\",\n \"centralindia\": \"cin\",\n \"centralus\": \"cus\",\n \"centraluseuap\": \"cuseuap\",\n \"eastasia\": \"ea\",\n \"eastus\": \"eus\",\n \"eastus2\": \"eus2\",\n \"eastus2euap\": \"eus2euap\",\n \"francecentral\": \"frc\",\n \"francesouth\": \"frs\",\n \"germanynorth\": \"gern\",\n \"germanywestcentral\": \"gerwc\",\n \"japaneast\": \"jae\",\n \"japanwest\": \"jaw\",\n \"jioindiacentral\": \"jioinc\",\n \"jioindiawest\": \"jioinw\",\n \"koreacentral\": \"koc\",\n \"koreasouth\": \"kors\",\n \"northcentralus\": \"ncus\",\n \"northeurope\": \"neu\",\n \"norwayeast\": \"nore\",\n \"norwaywest\": \"norw\",\n \"southafricanorth\": \"san\",\n \"southafricawest\": \"saw\",\n \"southcentralus\": \"scus\",\n \"southeastasia\": \"sea\",\n \"southindia\": \"sin\",\n \"swedencentral\": \"swc\",\n \"switzerlandnorth\": \"swn\",\n \"switzerlandwest\": \"sww\",\n \"uaecentral\": \"uaec\",\n \"uaenorth\": \"uaen\",\n \"uksouth\": \"uks\",\n \"ukwest\": \"ukw\",\n \"westcentralus\": \"wcus\",\n \"westeurope\": \"weu\",\n \"westindia\": \"win\",\n \"westus\": \"wus\",\n \"westus2\": \"wus2\",\n \"westus3\": \"wus3\"\n }\n}", | |||
| "$fxv#0": "{\r\n // Recommended abreviations: https://learn.microsoft.com/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations\r\n \"resourceTypeAbbreviations\" : {\r\n \"applicationGateway\": \"agw\",\r\n \"applicationInsights\": \"appi\",\r\n \"appService\": \"app\",\r\n \"azureFirewall\": \"azfw\",\r\n \"bastion\": \"bas\",\r\n \"containerAppsEnvironment\": \"cae\",\r\n \"containerRegistry\": \"cr\",\r\n \"cosmosDbNoSql\": \"cosno\",\r\n \"frontDoor\": \"afd\",\r\n \"frontDoorEndpoint\": \"fde\",\r\n \"frontDoorWaf\": \"fdfp\",\r\n \"keyVault\": \"kv\",\r\n \"logAnalyticsWorkspace\": \"log\",\r\n \"managedIdentity\": \"id\",\r\n \"networkInterface\": \"nic\",\r\n \"networkSecurityGroup\": \"nsg\",\r\n \"privateEndpoint\": \"pep\",\r\n \"privateLinkService\": \"pls\",\r\n \"publicIpAddress\": \"pip\",\r\n \"resourceGroup\": \"rg\",\r\n \"routeTable\": \"rt\",\r\n \"serviceBus\": \"sb\",\r\n \"serviceBusQueue\": \"sbq\",\r\n \"serviceBusTopic\": \"sbt\",\r\n \"storageAccount\": \"st\",\r\n \"virtualMachine\": \"vm\",\r\n \"virtualNetwork\": \"vnet\",\r\n \"redisCache\": \"redis\",\r\n \"cognitiveAccount\": \"cog\",\r\n \"openAiDeployment\": \"oaidep\",\r\n \"azureAISearch\": \"srch\",\r\n \"documentIntelligence\": \"di\",\r\n \"eventGridSystemTopic\": \"egst\",\r\n \"eventGridSubscription\": \"evgs\"\r\n },\r\n\r\n //copied from here: https://github.com/nianton/azure-naming/blob/main/datafiles/regionAbbreviations.json\r\n \"regionAbbreviations\" : {\r\n \"australiacentral\": \"auc\",\r\n \"australiacentral2\": \"auc2\",\r\n \"australiaeast\": \"aue\",\r\n \"australiasoutheast\": \"ause\",\r\n \"brazilsouth\": \"brs\",\r\n \"brazilsoutheast\": \"brse\",\r\n \"canadacentral\": \"canc\",\r\n \"canadaeast\": \"cane\",\r\n \"centralindia\": \"cin\",\r\n \"centralus\": \"cus\",\r\n \"centraluseuap\": \"cuseuap\",\r\n \"eastasia\": \"ea\",\r\n \"eastus\": \"eus\",\r\n \"eastus2\": \"eus2\",\r\n \"eastus2euap\": \"eus2euap\",\r\n \"francecentral\": \"frc\",\r\n \"francesouth\": \"frs\",\r\n \"germanynorth\": \"gern\",\r\n \"germanywestcentral\": \"gerwc\",\r\n \"japaneast\": \"jae\",\r\n \"japanwest\": \"jaw\",\r\n \"jioindiacentral\": \"jioinc\",\r\n \"jioindiawest\": \"jioinw\",\r\n \"koreacentral\": \"koc\",\r\n \"koreasouth\": \"kors\",\r\n \"northcentralus\": \"ncus\",\r\n \"northeurope\": \"neu\",\r\n \"norwayeast\": \"nore\",\r\n \"norwaywest\": \"norw\",\r\n \"southafricanorth\": \"san\",\r\n \"southafricawest\": \"saw\",\r\n \"southcentralus\": \"scus\",\r\n \"southeastasia\": \"sea\",\r\n \"southindia\": \"sin\",\r\n \"swedencentral\": \"swc\",\r\n \"switzerlandnorth\": \"swn\",\r\n \"switzerlandwest\": \"sww\",\r\n \"uaecentral\": \"uaec\",\r\n \"uaenorth\": \"uaen\",\r\n \"uksouth\": \"uks\",\r\n \"ukwest\": \"ukw\",\r\n \"westcentralus\": \"wcus\",\r\n \"westeurope\": \"weu\",\r\n \"westindia\": \"win\",\r\n \"westus\": \"wus\",\r\n \"westus2\": \"wus2\",\r\n \"westus3\": \"wus3\"\r\n }\r\n}", | |||
There was a problem hiding this comment.
I guess so. I only regenerated the json files
There was a problem hiding this comment.
Can we please test static on this one before merge?
There was a problem hiding this comment.
Attached a batch. Mind you however it will be red as the PSRule tests, much like the Balrog, currently do not pass
There was a problem hiding this comment.
BTW, if I recall correctly, this is. Windows vs Linux issue, where you get two different results. Have seen this before somewhere
There was a problem hiding this comment.
And confirmed. Just re-ran it from the WSL:
These line endings will be our downfall
There was a problem hiding this comment.
Alright, passes @eriqua
I guess we'll have to look into the settings.json vs extension.json files eventually to make sense of them. Last time I tried (easily half a year ago) I failed and no configuration seemed to affect how bicep renders the line endings.
arnoldna
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pipeline Reference
Type of Change
version.json:version.json.version.json.