Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extracting param as resource-derived type #15282

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Oct 11, 2024

Fixes #15036

I've implemented this so that I only show the option for resource-derived types when extracting parameters when the resource-derived type would not be a simple type. So in this case I just show 'object' as an option.
image

Whereas here's an example where I do show the option:
image

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Test this change out locally with the following install scripts (Action run 11448333736)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 11448333736
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 11448333736"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 11448333736
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 11448333736"

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   29m 41s ⏱️ - 12m 14s
11 373 tests  -      9  11 373 ✅  -      9  0 💤 ±0  0 ❌ ±0 
26 477 runs   - 13 186  26 477 ✅  - 13 186  0 💤 ±0  0 ❌ ±0 

Results for commit 0e4bc5f. ± Comparison against base commit 6dfa4ff.

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford force-pushed the sw/241007-extract-resderived branch 2 times, most recently from 2c2377f to 6f0fb7d Compare October 11, 2024 22:30
@StephenWeatherford StephenWeatherford marked this pull request as draft October 14, 2024 18:30
@StephenWeatherford StephenWeatherford marked this pull request as ready for review October 16, 2024 22:22
@StephenWeatherford
Copy link
Contributor Author

@shenglol Thanks!

@StephenWeatherford StephenWeatherford merged commit 12531f1 into main Oct 21, 2024
92 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/241007-extract-resderived branch October 21, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract parameter should support resource-derived types
2 participants