feat(custom-ca-trust): Enable custom_ca_trust_enabled in node_pools #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: Azure#438 Signed-off-by: Iago Santos Pardo <iago.santos.pardo@adfinis.com>
|
Thanks @isantospardo for opening this pr. For now, we won't merge the preview features since the service team might revoke them at any time, so I'd like to wait until this feature is GA. |
lonegunmanb
added
the
preview feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We would like to be able to enable custom_ca_trust_enabled within this module described in the upstream Terraform Kubernetes Cluster resource.
This feature is currently not implemented yet and it would let us configure the custom_ca, it is known it is in a preview state but it is already integrated into the latest available aks cluster provider
Issue number
#438
Checklist before requesting a review
CHANGELOG.mdfile