Use assertRaisesRegex instead of assertRaisesRegexp for Python 3.12 compatibility #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
reviewed
Dec 28, 2021
|
|
|
Ha. This is another evidence showing that Python 2 support should be dropped (#406). 🤣 |
|
Interestingly, we just added Python 3.11alpha into our test matrix in another PR, the test automation passed without the changes in this PR. Manually trying in a Python 3.11alpha environment, and the |
|
Probably the tests are getting skipped in test_client.py |
tirkarthi
changed the title
|
The removal was done 3.12 https://docs.python.org/3.12/whatsnew/3.12.html#removed |
|
@rayluo - please let's prioritize community contributions when possible and avoid keeping PRs open for longer than a few days / weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated unittest aliases were removed in python/cpython#28268 . The PR is backwards compatible with Python 2