build: add basic workflow to build PRs #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plexoos
force-pushed
the
add-workflow
branch
4 times, most recently
from
0725408
to
74cec24
Compare
Using esi-shell container
plexoos
force-pushed
the
add-workflow
branch
from
74cec24
to
2cbc98d
Compare
|
8 out of 100 photons have significantly different histories |
|
I found errors in the raindrop model. I am not sure this is because of that. When I tried to use CaTS for raindrop on GPU it did not work until I corrected the optical surface. Will propose a fix to the model today. |
|
Thank you Gabor! It would be nice to see if the issue can be reproduced with our tools, feel free to create an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using esi-shell container
Added a basic test comparing photon histories for GPU and CPU based simulations.