refactor: embed SEvt into G4App #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
No concerns from clang-tidy.
Click here for the full clang-format patch
diff --git a/src/simg4ox.cpp b/src/simg4ox.cpp
index c23c151..e857c9e 100644
--- a/src/simg4ox.cpp
+++ b/src/simg4ox.cpp
@@ -47 +46,0 @@ using namespace std;
-
@@ -75 +74,3 @@ struct PrimaryGenerator : G4VUserPrimaryGeneratorAction
- PrimaryGenerator(SEvt *sev) : sev(sev) {}
+ PrimaryGenerator(SEvt *sev) : sev(sev)
+ {
+ }
@@ -117 +118,3 @@ struct EventAction : G4UserEventAction
- EventAction(SEvt *sev) : sev(sev) {}
+ EventAction(SEvt *sev) : sev(sev)
+ {
+ }
@@ -152 +155,3 @@ struct SteppingAction : G4UserSteppingAction
- SteppingAction(SEvt *sev) : sev(sev) {}
+ SteppingAction(SEvt *sev) : sev(sev)
+ {
+ }
@@ -208 +213,3 @@ struct TrackingAction : G4UserTrackingAction
- TrackingAction(SEvt *sev) : sev(sev) {}
+ TrackingAction(SEvt *sev) : sev(sev)
+ {
+ }
@@ -284,5 +291,2 @@ struct G4App
- : sev(SEvt::HighLevelCreate(SEvt::ECPU)),
- det_cons_(new DetectorConstruction(gdml_file)),
- prim_gen_(new PrimaryGenerator(sev)),
- event_act_(new EventAction(sev)),
- stepping_(new SteppingAction(sev)),
+ : sev(SEvt::HighLevelCreate(SEvt::ECPU)), det_cons_(new DetectorConstruction(gdml_file)),
+ prim_gen_(new PrimaryGenerator(sev)), event_act_(new EventAction(sev)), stepping_(new SteppingAction(sev)),
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Cpp-linter Review
No concerns from clang-tidy.
Click here for the full clang-format patch
diff --git a/src/simg4ox.cpp b/src/simg4ox.cpp
index c776796..e857c9e 100644
--- a/src/simg4ox.cpp
+++ b/src/simg4ox.cpp
@@ -47 +46,0 @@ using namespace std;
-
Have any feedback or feature suggestions? Share it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.