Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conda environement for bira theme #2256

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Jun 21, 2024

Description

Support for the showing the conda environment for the bira theme. This will prioritise the virtualenv prompt.

Motivation and Context

I usually got confused whether conda is activated or not, then found that it is in fact activated but theme doesn't handle CONDA_DEFAULT_ENV variable.

How Has This Been Tested?

Locally, sourcing the new script with new changes and activating the environment

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jun 25, 2024

Hey @NoahGorny long time no see. Can we merge this?

@seefood seefood merged commit 662c1df into Bash-it:master Nov 6, 2024
5 of 6 checks passed
@tbhaxor tbhaxor deleted the themes/bira branch November 6, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants