Merge pull request #1744 from BladeRunnerJS/fix-1743/change-ListenerC…

…ompatUtil-to-use-typeof changing ListenerCompatUtil to use typeof when checking listener meth…
BladeRunnerJS · Nov 8, 2016 · 6ab0496 · 6ab0496
2 parents 895b332 + 154f7ba
commit 6ab0496
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 1 deletion.
diff --git a/brjs-sdk/sdk/libs/javascript/br-presenter/src/br/presenter/util/ListenerCompatUtil.js b/brjs-sdk/sdk/libs/javascript/br-presenter/src/br/presenter/util/ListenerCompatUtil.js
@@ -12,7 +12,7 @@ ListenerCompatUtil.enhance = function(listenerMethod) {
 			notifyImmediately = method;
 		}
 		else {
-			if(!listener[method] || !(listener[method] instanceof Function)) {
+			if(!listener[method] || !(typeof listener[method] === 'function')) {
 				throw new TypeError("No such method '" + method + "' on the listener object.");
 			}
 

diff --git a/releases/v1.5.4.json → releases/archive/v1.5.4.json b/releases/v1.5.4.json → releases/archive/v1.5.4.json
diff --git a/releases/v1.5.4.md → releases/archive/v1.5.4.md b/releases/v1.5.4.md → releases/archive/v1.5.4.md
diff --git a/releases/v1.5.5.json b/releases/v1.5.5.json
@@ -0,0 +1,5 @@
+{
+    "milestone": "1.5.5",
+    "name": "BladeRunnerJS 1.5.5",
+    "prerelease": false
+}
diff --git a/releases/v1.5.5.md b/releases/v1.5.5.md
@@ -0,0 +1,7 @@
+## BladeRunnerJS @tagVersion@
+
+BladeRunnerJS @tagVersion@ contains one minor bug fix.
+
+### Bug fixes
+
+- Fix provided to ensure ListenerCompatUtil correctly checks typeof of listener methods that works for all cases.