Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for latest versions compatibility #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexKay28
Copy link

Added explicit typing into "bf16" condition usage section.

I have seen a lot of messages in discord chats and struggled personally with this. This PR doesn't change anything in functionality, but just makes code more clear and friendly to the older versions of torch packages

@BlinkDL
Copy link
Owner

BlinkDL commented May 2, 2023

It works if you use deepspeed==0.7.0 pytorch-lightning==1.9.2 please try :)

@AlexKay28
Copy link
Author

AlexKay28 commented May 3, 2023

@BlinkDL yes, it works, i knew it :) But I noticed you don't provide in the project requirements.txt file or something + it might be not possible to install needed versions in some environments, so I decided to add this typing to avoid such kind of problems.

Feel free to close this issue without applying changes if you think it's redundant, but I have seen some messages from people with this problem :/ I just thought it could make the code safer and that's it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants