Switched from J2V8 to Javet, closes #2 #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved command handling and added resource filtering * Updated plugin's main class * Fixed Javet implementation
# Conflicts: # pom.xml # src/main/java/com/violeth/blockjs/blockjs/BlockJS.java # src/main/java/com/violeth/blockjs/blockjs/CommandInterface.java # src/main/java/com/violeth/blockjs/blockjs/Commands.java # src/main/java/com/violeth/blockjs/blockjs/commands/Command.java # src/main/java/com/violeth/blockjs/blockjs/commands/HelpCommand.java # src/main/java/com/violeth/blockjs/blockjs/commands/VersionCommand.java # src/main/java/com/violeth/blockjs/blockjs/jsinterface/JSRunner.java # src/main/java/com/violeth/blockjs/blockjs/jsinterface/mcinterface/Chat.java # src/main/java/com/violeth/blockjs/blockjs/jsinterface/mcinterface/Player.java # src/main/java/com/violeth/blockjs/blockjs/jsinterface/mcinterface/World.java # src/npm-package/src/chat/index.ts # src/npm-package/src/entities/player.ts # src/test/java/com/violeth/blockjs/blockjs/jsinterface/JSInterfaceTest.java # src/test/java/com/violeth/blockjs/blockjs/jsinterface/JSRunnerTest.java
|
If someone would like to review and make sure I didn't miss anything it would be greatly appreciated |
TheGreatViolet
added
the
feat: core
|
Same thing happens here |
|
Marking this as a draft for now, too many bugs to justify merging |
|
I'm going to close this pull request as the current rewrite of the core plugin into Kotlin pretty much makes this obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type:
Bugfix
Feature addition
Refactor
Contribution guidelines related change
Other (specify):
Why should this pull request be merged? (If this PR closes an issue you can just link that).
Closes #2
Checklist
I have provided a convincing reason on why this pull request should be merged,
or I linked an issue that this pull request closes.
If this pull request creates a breaking change, it was approved in a separate issue.