Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated dependencies #277

Merged
merged 8 commits into from
Nov 9, 2024
Merged

updated dependencies #277

merged 8 commits into from
Nov 9, 2024

Conversation

DaanV2
Copy link
Contributor

@DaanV2 DaanV2 commented Nov 9, 2024 •
edited
Loading

Problem

  • Vanilla sound files are not found if they are in fact vanilla files

Solution

  • Added sound vanilla files to vanilla data library
  • Updated the diagnosed to check those lists

Related Issues

#216
#276

This was linked to issues Nov 9, 2024
Vanilla sound path considered non-existent #216
Closed
Sound Filepath Schema - vanilla sound paths reused in new sound definitions give resourcepack.sound.missing error #276
Closed
@DaanV2 DaanV2 merged commit 47f02a2 into main Nov 9, 2024
3 checks passed
@DaanV2 DaanV2 deleted the feature/fixing-sounds branch November 9, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@DaanV2