DateTimePlugin: Adding analog clock view configuration #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML: * Make config container responsive No margin below small devices * Add radio button groups for analog mode * Allow to customize seconds visualisation over web pages (radio buttons). Webserver: Added keyword DISPLAY_HEIGHT and DISPLAY_WIDTH. They get replaced with the resolution of the display. Used to enable/disable resolution dependend elements.
BlueAndi
requested changes
Nov 5, 2024
Addressed code review findings BlueAndi#198
User proper " />" terminator if body is empty.
BlueAndi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML:
Webserver:
Added keyword DISPLAY_HEIGHT and DISPLAY_WIDTH.
They get replaced with the resolution of
the display. Used to enable/disable resolution
dependend elements.