Skip to content

Commit

Permalink
Merge pull request #3445 from BrentOzarULTD/dev
Browse files Browse the repository at this point in the history
2024-02-22 Release
  • Loading branch information
BrentOzar authored Feb 22, 2024
2 parents ab68347 + ea26dd4 commit b9695da
Show file tree
Hide file tree
Showing 33 changed files with 1,286 additions and 387 deletions.
59 changes: 59 additions & 0 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
name: First Responder Kit Integration Tests

on:
push:
workflow_dispatch:
pull_request:
types: [opened, review_requested, synchronize]

jobs:
build:
name: Build
runs-on: ubuntu-latest
strategy:
matrix:
SQL_ENGINE_VERSION: [2017,2019,2022]
COLLATION: [SQL_Latin1_General_CP1_CS_AS]


steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Install SqlServer Module
shell: pwsh
run: |
Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
Install-Module SqlServer
- name: Install SQL Server
uses: potatoqualitee/mssqlsuite@v1.7
with:
install: sqlengine
version: ${{ matrix.SQL_ENGINE_VERSION }}
collation: ${{ matrix.COLLATION }}

- name: Check SQL Install
run: |
sqlcmd -S localhost -U sa -P dbatools.I0 -d tempdb -Q "SELECT @@version as Version;" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d tempdb -Q "SELECT SERVERPROPERTY('Collation') AS Collation;" -I -b -t 60
- name: Deploy FRK
run: |
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzCache.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzWho.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_Blitz.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzFirst.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzAnalysis.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzBackups.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzIndex.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzInMemoryOLTP.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzLock.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzQueryStore.sql" -I -b -t 60
sqlcmd -S localhost -U sa -P dbatools.I0 -d master -Q "SELECT * FROM sys.procedures WHERE name LIKE 'sp_Blitz%';" -I -b -t 60
- name: Run Pester Tests
shell: pwsh
run: |
cd tests
./run-tests.ps1
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ Note that if you're not ready to get started coding in the next week, or if you

We're not picky at all about style, but a few things to know:

Don't touch the files that start with Install, like Install-All-Scripts.sql. Those are dynamically generated. You only have to touch the ones that start with sp_.

Your code needs to compile & run on all currently supported versions of SQL Server. It's okay if functionality degrades, like if not all features are available, but at minimum the code has to compile and run.

Your code must handle:
Expand Down
2 changes: 1 addition & 1 deletion Deprecated/sp_BlitzIndex_SQL_Server_2005.sql
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Known limitations of this version:
-- Example 1: index creates use ONLINE=? instead of ONLINE=ON / ONLINE=OFF. This is because it's important for the user to understand if it's going to be offline and not just run a script.
-- Example 2: they do not include all the options the index may have been created with (padding, compression filegroup/partition scheme etc.)
-- (The compression and filegroup index create syntax isn't trivial because it's set at the partition level and isn't trivial to code. Two people have voted for wanting it so far.)
- Doesn't advise you about data modeling for clustered indexes and primary keys (primarily looks for signs of insanity.)
- Doesn't advise you about data modeling for clustered indexes and primary keys (primarily looks for signs of problems.)
- Found something? Let us know at help@brentozar.com.
Thanks for using sp_BlitzIndex(TM)!
Expand Down
Loading

0 comments on commit b9695da

Please sign in to comment.