Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getMetapropertyOptionsById function #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nyroDev
Copy link

@nyroDev nyroDev commented May 25, 2021

There is a small error in AssetBankManager

According to the documentation, we should use the propertyID in the URL when retrieving option for a specific meta property.

This PR simply add the parameter and use it to fix it.

@TimBloembergen
Copy link
Contributor

Hi @nyroDev, The endpoint that you change with this PR is a valid endpoint, you can review the documentation on it here: https://bynder.docs.apiary.io/#reference/metaproperties/metaproperty-option-operations/retrieve-metaproperty-options-by-ids

The one you changed it too is a separate endpoint, documented on this page https://bynder.docs.apiary.io/#reference/metaproperties/metaproperty-option-operations/retrieve-metaproperty-options

@nyroDev
Copy link
Author

nyroDev commented Apr 11, 2022

Ok, so there is a function missing for my use case.
I'll update my PR ASAP to reflect that.

@nyroDev
Copy link
Author

nyroDev commented Nov 27, 2023

@TimBloembergen I finnaly updated the code to add a new specific function as requested

@nyroDev nyroDev changed the title Fix getMetapropertyOptions according to use a propertyID parameter Add getMetapropertyOptionsById function Nov 27, 2023
@schmidfelix
Copy link

Hey there, sorry to ping you - any news on that? 😅

@TimBloembergen
Copy link
Contributor

Sorry, this one fell through. I will get my team to look at the PR, review and release it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants