Split adapter and wrapper into different entities #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I work on projects where I cannot use the
Adapter(..)
directly. I need to call the*.ServeHTTP(..)
method directly.Changes
Adapter(..)
and the included wrapper into different entities:Adapter(..)
: Which will work as before (see tests)ResponseWriterFactoryFactory.Create(..)
: Which is used to create a wrappedhttp.ResponseWriter
from a given one, which is compressing (if requested).adapter.go
into other files (likeconfig.go
andresponse_writer_factory.go
)MinSizeRequestFunc(func(*http.Request) (int, error))
to be able to used instead ofMinSize(..)
. Makes it able to determineminSize
on each call ofResponseWriterFactoryFactory.Create(..)
based on the request.ErrorHandler(..)
to be able to react to errors inside of the handling chain of httpcompression.ErrHijackerNotSupported
instead of enclosed error to be able to check for it directly.