Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rust] add options module #1632

Merged
merged 34 commits into from
Aug 19, 2024
Merged

[rust] add options module #1632

merged 34 commits into from
Aug 19, 2024

Conversation

prateekmedia
Copy link
Member

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Add CCX Options in Rust module, successor to #1559

PunitLodha
PunitLodha requested changes Aug 10, 2024
View reviewed changes
src/rust/lib_ccxr/src/common/constants.rs Outdated Show resolved Hide resolved
src/rust/lib_ccxr/src/util/encoding.rs Outdated Show resolved Hide resolved
PunitLodha
PunitLodha approved these changes Aug 19, 2024
View reviewed changes
src/rust/src/common.rs Outdated Show resolved Hide resolved
@prateekmedia prateekmedia merged commit 98a85e1 into CCExtractor:master Aug 19, 2024
16 of 18 checks passed
@prateekmedia prateekmedia deleted the rust-options-module branch August 19, 2024 16:34
IshanGrover2004 pushed a commit to IshanGrover2004/ccextractor-fork that referenced this pull request Aug 23, 2024
@prateekmedia @elbertronnie @IshanGrover2004
[rust] add options module (CCExtractor#1632)
ca2185d 
* create lib_ccxr and libccxr_exports

* add log module

* add encoding module

* add common constants module

* add time units module

* add options module

* chore: update Cargo lock files

* fix: remove duplicacy

* fix: doc error

* fix: errors

* fix: remove time folder

* chore: lint fix

* chore: lint fix

* fix: errors

* fix: add time mod to utils

* fix: unreachable code

* fix: logging function

* chore: update lock file

* chore: remove duplicate comment

* feat: blend parser and options

* chore: lint fix

* chore: lint fix

* fix: imports

* fix: error in version

* chore: lint fixes

* chore: more lint fixes

* fix: error in svc

* chore: remove from options function

---------

Co-authored-by: Elbert Ronnie <elbert.ronniep@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshanGrover2004 IshanGrover2004 IshanGrover2004 left review comments

@PunitLodha PunitLodha PunitLodha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prateekmedia @PunitLodha @IshanGrover2004 @elbertronnie