Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] add teletext and encoders_helpers module #1635

Merged
merged 29 commits into from
Aug 27, 2024
Merged

[FEAT] add teletext and encoders_helpers module #1635

merged 29 commits into from
Aug 27, 2024

Conversation

prateekmedia
Copy link
Member

@prateekmedia prateekmedia commented Aug 19, 2024 •
edited
Loading

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR is a successor of #1560

elbertronnie and others added 21 commits August 27, 2023 17:03
@elbertronnie
create lib_ccxr and libccxr_exports
8014d8b
@elbertronnie
add bits and levenshtein module
4f0dc69
@elbertronnie
add log module
8f348fe
@elbertronnie
add encoding module
676ef84
@elbertronnie
add common constants module
f4d4d7c
@elbertronnie
add time units module
49cdd1f
@elbertronnie
Merge branch 'add-log-module'
6db74b7
@elbertronnie
Merge branch 'add-constants-module'
4e44c55
@elbertronnie
Merge branch 'add-encoding-module'
8bf7180
@elbertronnie
add options module
e60b460
@elbertronnie
Merge branch 'add-bits-and-levenshtein-module'
6d354ac
@elbertronnie
add teletext module
f8eb1a7
@prateekmedia
Merge remote-tracking branch 'elb/add-teletext-module' into rust-tele…
0da3764 
…text
@prateekmedia
chore: remove outdated
b2bada4
@prateekmedia
chore: update lock files
201233e
@prateekmedia
chore: fix naming
23d4b4e
@prateekmedia
fix: reference to TeletextConfig
e89dd74
@prateekmedia
fix: issue with ts_forced_program default value
ba026e2
@prateekmedia
fix: use correct definition
cb6bb54
@prateekmedia
chore: lint warnings
4ab9181
@prateekmedia
fix: example code
e6ff963
@ccextractor-bot

This comment was marked as outdated.

Sign in to view
@ccextractor-bot

This comment was marked as outdated.

Sign in to view
@prateekmedia prateekmedia changed the title [feat(rust)] add telext module [feat(rust)] add teletext and encoders_helpers module Aug 21, 2024
@prateekmedia prateekmedia changed the title [feat(rust)] add teletext and encoders_helpers module [FEAT] add teletext and encoders_helpers module Aug 21, 2024
@prateekmedia prateekmedia mentioned this pull request Aug 23, 2024
Closed
10 tasks
@prateekmedia prateekmedia mentioned this pull request Aug 23, 2024
Merged
10 tasks
@prateekmedia
Copy link
Member Author

@PunitLodha Could you review this PR?

@prateekmedia prateekmedia merged commit 90f9f0a into CCExtractor:master Aug 27, 2024
16 of 18 checks passed
@prateekmedia prateekmedia deleted the rust-teletext branch August 27, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PunitLodha PunitLodha PunitLodha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prateekmedia @ccextractor-bot @PunitLodha @elbertronnie