Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All struct parameters should name match models #416

Open
seabbs opened this issue Aug 2, 2024 · 1 comment
Open

All struct parameters should name match models #416

seabbs opened this issue Aug 2, 2024 · 1 comment
Labels
enhancement New feature or request EpiAware

Comments

@seabbs
Copy link
Collaborator

seabbs commented Aug 2, 2024

Currently we have either:

  • names that don't full match
  • names that match but have a _prior tag

I don't think the latter adds anything as it being in the prior should be clear its the prior model.

I think we should standardise so that all parameters in the model are defined with the same name in the structs. As this may be a fairly disruptive refactor I think we should do this at the same time as making everything a submodel (i.e #372).

@seabbs seabbs added enhancement New feature or request EpiAware labels Aug 2, 2024
@SamuelBrand1
Copy link
Collaborator

Hard agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EpiAware
Projects
None yet
Development

No branches or pull requests

2 participants