Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MirrorType structure #8

Open
wants to merge 5 commits into
base: refactor/create-mirror/move_intelligence
Choose a base branch
from
Open

Remove MirrorType structure #8

wants to merge 5 commits into from

Conversation

thierryantoun
Copy link
Member

@thierryantoun thierryantoun commented Mar 22, 2024 •
edited by pzehner
Loading

This PR aims to delete the MirrorType structure in order to chose the already existing MirrorViewType structure which includes its properties.

This PR is part of a of a larger effort which aims to fix kokkos#6842.

@pzehner pzehner marked this pull request as ready for review March 22, 2024 15:37
tpadioleau
tpadioleau approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that the initial intent was to have a structure dedicated to create_mirror-like functions and an other for create_mirror_view-like functions.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@pzehner pzehner

@thierryantoun thierryantoun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thierryantoun @tpadioleau @pzehner