Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up dockerfiles #124

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Clean up dockerfiles #124

merged 6 commits into from
Mar 5, 2024

Conversation

benlee0423
Copy link

@benlee0423 benlee0423 commented Mar 2, 2024 •
edited
Loading

  1. Remove unused and redundant arguments and variables.
  2. Remove redundant intermediate images in deps Dockerfile.
  3. Remove old comments that were never used.
  4. Remove conditional downloads of latest version for dependent libraries, which never been used. It uses specific versions.

@benlee0423 benlee0423 linked an issue Mar 2, 2024 that may be closed by this pull request
Clean up Dockerfiles #122
Closed
@arpita0911patel arpita0911patel merged commit ff7d05d into main Mar 5, 2024
18 checks passed
@benlee0423 benlee0423 deleted the 122-clean-up-dockerfiles branch March 22, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpita0911patel arpita0911patel arpita0911patel approved these changes

@ZacharyWills ZacharyWills Awaiting requested review from ZacharyWills

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up Dockerfiles
2 participants
@benlee0423 @arpita0911patel